forked from pancakeswap/pancake-frontend
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ariza front #1
Open
howmarketing
wants to merge
22
commits into
fluxus-finance:develop
Choose a base branch
from
howmarketing:ariza_front
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ariza front #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendencies abrout eslint, prettier, babel, etc. And changin typescript version
…ing and js dependencies modules
…omponent. All oters detailed svgs must to be provided from here
…HERE. Some configs was hardcode to package react webpack config file and pancakeswap eslint config file, becouse the amount of conflict versions was taking so long to figure out how to do a safe packages update, and it was so much harder then just make these changes.
… (checkJs) propperty, to make development must equal as possible with error reporting comparing to production runtime deploy
…ilded in development environment as the production to.
…r UI components used
…ted packages included on this application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First base necessary changes to be able to build the application such as dev environment or/and basic production build with corresponds typescripts checks.
These changes are just part of a several hours working on typescript compiler configs, to get to match local IDE eslint display`s error and warnings as the runtime build application.
Such hours of effort in this type of configuration was really necessary, as many components construction type errors and conflict between dependent packages became invisible when the application was deployed, breaking features in several places in it, not having an automatic signal to show-up for us where the break are, such problems were only could be founded after some kinds of commits works, turning the project into a refactory first.
The upcoming pull request orders (before 4:00pm), are, probably will be just removing trash, what already are in progress. But, right now, the current deploy without these trash, it`s breaked and could not be online until some data trafic issues between components can be fixed (Already working on it, and it could be doned about 17:00pm).